[Anthill-dev] RE: Bug in ProfileRepositoryAdapter.revert()?

[Chad Woolley]

Hi,

I think my problem was due to misconfiguring the paths in my
project after migrating to CVS.  However, I still don't
understand why the cleanup of the working directory is
dependent on the debugEnabled status...

Thanks,
Chad

-----Original Message-----
From: anthill-dev-admin at lists.urbancode.com
[mailto:anthill-dev-admin at lists.urbancode.com]On Behalf Of
anthill-dev-request at lists.urbancode.com
Sent: Tuesday, May 06, 2003 9:01 AM
To: anthill-dev at lists.urbancode.com
Subject: Anthill-dev digest, Vol 1 #16 - 1 msg


Send Anthill-dev mailing list submissions to
	anthill-dev at lists.urbancode.com

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.urbancode.com/mailman/listinfo/anthill-dev
or, via email, send a message with subject or body 'help' to
	anthill-dev-request at lists.urbancode.com

You can reach the person managing the list at
	anthill-dev-admin at lists.urbancode.com

When replying, please edit your Subject line so it is more specific
than "Re: Contents of Anthill-dev digest..."


Today's Topics:

   1. Bug in ProfileRepositoryAdapter.revert()? (Chad Woolley)

--__--__--

Message: 1
From: "Chad Woolley" <chad_woolley at choicehotels.com>
To: <anthill-dev at lists.urbancode.com>
Date: Mon, 5 May 2003 14:00:56 -0700
Subject: [Anthill-dev] Bug in ProfileRepositoryAdapter.revert()?

Hi,

I think I found a possible bug, but I am not sure because it seems like it
would have been caught by now.  I am using AH OS 1.6.3.67, and have just
migrated to CVS from VSS.

The bug I saw is that a change that I committed was not picked up in a
subsequent build.  When I looked into it, I saw that the working directory
contained the old version, and when I ran a new build, the new version was
not checked out.

When I looked at the ProfileRepositoryAdapter.revert() method, I see the
following code:


    public void revert() throws RepositoryException {
        // implementations will differ for each SCCS
        try {
            log.info("Cleaning up local files: ");
            if (!log.isDebugEnabled()) {
                File file = new File(getLocalProjectDirName());
                FileRemover.removeFile(file);
            }
        }
        catch (Exception e) {
            throw new RepositoryException("revert failed", e);
        }
    }


It looks to me that this logic will not be executed if Debug mode is
enabled, which doesn't seem correct - shouldn't it always be executed?  I'm
not really sure if this is my problem, because I'm not really sure how to
tell if I have Debug mode enabled (what log properties file would I be using
by default?)

Also, I'm not sure if the CVS checkout should get the new file version by
default, even if the directory is not cleaned.  If this is the case, why
didn't I get the new version?

Thanks in advance to anyone who can shed some light on this.

-- Chad



--__--__--

_______________________________________________
Anthill-dev mailing list
Anthill-dev at lists.urbancode.com
http://lists.urbancode.com/mailman/listinfo/anthill-dev


End of Anthill-dev Digest