[Anthill-dev] VSS building broken in 1.7.1

[Gudlaugur Egilsson]

Hi all 

I downloaded 1.7.1 yesterday in order to get SubVersion support. Unfortunately,
we've got to support VSS for some time to come. However, I found VSS building 
to be broken in this build. After some bughunting, I found the command lines generated
by 1.7.1 are not valid:

Version 1.6.3 would create a vss checkout command like this:

cmd /x/c cd /d "E:\Anthill\work\Calidris\Projects\CalidrisSoftwareSuite4.0\implementation" && set "SSDIR=I:\" && "E:\Applications\Micros~1\Common\VSS\win32\ss" cp "$/Calidris/Projects/CalidrisSoftwareSuite4.0/implementation/" -Y"build","build" && "E:\Applications\Micros~1\Common\VSS\win32\ss" get *   -Y"build","build" -R -I-Y -O-

But 1.7.1 creates a checkout command like this:

cmd /x/c cd /d E:\Anthill\work\Calidris\Projects\CalidrisSoftwareSuite4.0\implementation && set SSDIR=I:\ && E:\Applications\Micros~1\Common\VSS\win32\ss cp $/Calidris/Projects/CalidrisSoftwareSuite4.0/implementation/ -Ybuild,build && E:\Applications\Micros~1\Common\VSS\win32\ss get * -Ybuild,build -R -I-Y -O-  

The difference is quite obviously that doublequotes are missing in 1.7.1.

The culprit is a change in the ProfileRepositoryAdapter.java executeCommand, which passes the 
commandline through toArray(String command), which causes the command execution to
end in a call to getRuntime().exec(String []).

I find it likely that this method of executing commands is not  compatible with multi-command
execution like is being performed in this case. Therefore I believe it would be advisable to cease using
this method in a Windows environment.

Thanks

------------------------------------------
Calidris
Guðlaugur Stefán Egilsson
Software Engineer
gudlaugur.egilsson at calidris.com <mailto:gudlaugur.egilsson at calidris.com>
Vesturhlid 7
105 Reykjavik
Iceland
tel: +354 525 9121
mobile: +354 862 4884