[Anthill-dev] Subversion adapter patch

[Jim Hague]

Attached is a patch for the Subversion adapter. It fixes two problems:

1. After a successful build, the Subversion adapter in CVS tags the
   source tree at the point it was at when the build completed. If any
   checkin has happened during the checkout/build, it will be included
   in the tag despite it not being in the build.

   The fix (which I have submitted before but hasn't made it into CVS)
   is to grab the revision number of the checkout at checkout, and tag
   at that revision.

2. Subversion projects will repeat a successful build unnecessarily.
   When collecting changes since the last successful build, the adapter
   executes 'svn log -r {date of last build}:HEAD'. I'd expected
   Subversion to list changes since the given date. Actually it lists
   revisions starting with the revision current at the given date.
   After a successful build the date is advanced to the time of the
   start of the successful build, but on the next build cycle the
   revision triggering the first build is still the revision
   current at the time of last successful build. It's only after
   a second successful build that the time moves to a point after
   the next repository change, the incrementing of the build number
   after the first build. The fix is simple; when collecting revisions,
   ignore any from before the last successful build date.

There is one other minor change. If running on 1.4 or greater I try to parse
the Subversion timezone. Oh, and fixing what looks to me like indentation
wrongness.

Finally, please could someone fix the bad line endings at the start of
AnthillFlushQueueServlet.java.
-- 
Jim Hague - jim.hague at acm.org          Never trust a computer you can't lift.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Anthill.patch.svn2
Type: text/x-diff
Size: 14695 bytes
Desc: not available
Url : http://lists.urbancode.com/pipermail/anthill-dev/attachments/20060125/ad520209/Anthill.patch.bin